ContainerControllerResolverTest.php 10 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308
  1. <?php
  2. /*
  3. * This file is part of the Symfony package.
  4. *
  5. * (c) Fabien Potencier <fabien@symfony.com>
  6. *
  7. * For the full copyright and license information, please view the LICENSE
  8. * file that was distributed with this source code.
  9. */
  10. namespace Symfony\Component\HttpKernel\Tests\Controller;
  11. use Psr\Container\ContainerInterface;
  12. use Psr\Log\LoggerInterface;
  13. use Symfony\Component\Debug\ErrorHandler;
  14. use Symfony\Component\DependencyInjection\Container;
  15. use Symfony\Component\HttpFoundation\Request;
  16. use Symfony\Component\HttpKernel\Controller\ContainerControllerResolver;
  17. class ContainerControllerResolverTest extends ControllerResolverTest
  18. {
  19. public function testGetControllerService()
  20. {
  21. $container = $this->createMockContainer();
  22. $container->expects($this->once())
  23. ->method('has')
  24. ->with('foo')
  25. ->willReturn(true);
  26. $container->expects($this->once())
  27. ->method('get')
  28. ->with('foo')
  29. ->willReturn($this)
  30. ;
  31. $resolver = $this->createControllerResolver(null, $container);
  32. $request = Request::create('/');
  33. $request->attributes->set('_controller', 'foo:controllerMethod1');
  34. $controller = $resolver->getController($request);
  35. $this->assertInstanceOf(\get_class($this), $controller[0]);
  36. $this->assertSame('controllerMethod1', $controller[1]);
  37. }
  38. public function testGetControllerInvokableService()
  39. {
  40. $invokableController = new InvokableController('bar');
  41. $container = $this->createMockContainer();
  42. $container->expects($this->once())
  43. ->method('has')
  44. ->with('foo')
  45. ->willReturn(true)
  46. ;
  47. $container->expects($this->once())
  48. ->method('get')
  49. ->with('foo')
  50. ->willReturn($invokableController)
  51. ;
  52. $resolver = $this->createControllerResolver(null, $container);
  53. $request = Request::create('/');
  54. $request->attributes->set('_controller', 'foo');
  55. $controller = $resolver->getController($request);
  56. $this->assertEquals($invokableController, $controller);
  57. }
  58. public function testGetControllerInvokableServiceWithClassNameAsName()
  59. {
  60. $invokableController = new InvokableController('bar');
  61. $className = __NAMESPACE__.'\InvokableController';
  62. $container = $this->createMockContainer();
  63. $container->expects($this->once())
  64. ->method('has')
  65. ->with($className)
  66. ->willReturn(true)
  67. ;
  68. $container->expects($this->once())
  69. ->method('get')
  70. ->with($className)
  71. ->willReturn($invokableController)
  72. ;
  73. $resolver = $this->createControllerResolver(null, $container);
  74. $request = Request::create('/');
  75. $request->attributes->set('_controller', $className);
  76. $controller = $resolver->getController($request);
  77. $this->assertEquals($invokableController, $controller);
  78. }
  79. public function testNonInstantiableController()
  80. {
  81. $container = $this->createMockContainer();
  82. $container->expects($this->once())
  83. ->method('has')
  84. ->with(NonInstantiableController::class)
  85. ->willReturn(false)
  86. ;
  87. $resolver = $this->createControllerResolver(null, $container);
  88. $request = Request::create('/');
  89. $request->attributes->set('_controller', [NonInstantiableController::class, 'action']);
  90. $controller = $resolver->getController($request);
  91. $this->assertSame([NonInstantiableController::class, 'action'], $controller);
  92. }
  93. /**
  94. * @expectedException \LogicException
  95. * @expectedExceptionMessage Controller "Symfony\Component\HttpKernel\Tests\Controller\ImpossibleConstructController" cannot be fetched from the container because it is private. Did you forget to tag the service with "controller.service_arguments"?
  96. */
  97. public function testNonConstructController()
  98. {
  99. $container = $this->getMockBuilder(Container::class)->getMock();
  100. $container->expects($this->at(0))
  101. ->method('has')
  102. ->with(ImpossibleConstructController::class)
  103. ->willReturn(true)
  104. ;
  105. $container->expects($this->at(1))
  106. ->method('has')
  107. ->with(ImpossibleConstructController::class)
  108. ->willReturn(false)
  109. ;
  110. $container->expects($this->atLeastOnce())
  111. ->method('getRemovedIds')
  112. ->with()
  113. ->willReturn([ImpossibleConstructController::class => true])
  114. ;
  115. $resolver = $this->createControllerResolver(null, $container);
  116. $request = Request::create('/');
  117. $request->attributes->set('_controller', [ImpossibleConstructController::class, 'action']);
  118. if (\PHP_VERSION_ID < 70100) {
  119. ErrorHandler::register();
  120. try {
  121. $resolver->getController($request);
  122. } finally {
  123. restore_error_handler();
  124. restore_exception_handler();
  125. }
  126. } else {
  127. $resolver->getController($request);
  128. }
  129. }
  130. public function testNonInstantiableControllerWithCorrespondingService()
  131. {
  132. $service = new \stdClass();
  133. $container = $this->createMockContainer();
  134. $container->expects($this->atLeastOnce())
  135. ->method('has')
  136. ->with(NonInstantiableController::class)
  137. ->willReturn(true)
  138. ;
  139. $container->expects($this->atLeastOnce())
  140. ->method('get')
  141. ->with(NonInstantiableController::class)
  142. ->willReturn($service)
  143. ;
  144. $resolver = $this->createControllerResolver(null, $container);
  145. $request = Request::create('/');
  146. $request->attributes->set('_controller', [NonInstantiableController::class, 'action']);
  147. $controller = $resolver->getController($request);
  148. $this->assertSame([$service, 'action'], $controller);
  149. }
  150. /**
  151. * @expectedException \LogicException
  152. * @expectedExceptionMessage Controller "app.my_controller" cannot be fetched from the container because it is private. Did you forget to tag the service with "controller.service_arguments"?
  153. */
  154. public function testExceptionWhenUsingRemovedControllerService()
  155. {
  156. $container = $this->getMockBuilder(Container::class)->getMock();
  157. $container->expects($this->at(0))
  158. ->method('has')
  159. ->with('app.my_controller')
  160. ->willReturn(false)
  161. ;
  162. $container->expects($this->atLeastOnce())
  163. ->method('getRemovedIds')
  164. ->with()
  165. ->willReturn(['app.my_controller' => true])
  166. ;
  167. $resolver = $this->createControllerResolver(null, $container);
  168. $request = Request::create('/');
  169. $request->attributes->set('_controller', 'app.my_controller');
  170. $resolver->getController($request);
  171. }
  172. /**
  173. * @expectedException \LogicException
  174. * @expectedExceptionMessage Controller "app.my_controller" cannot be called without a method name. Did you forget an "__invoke" method?
  175. */
  176. public function testExceptionWhenUsingControllerWithoutAnInvokeMethod()
  177. {
  178. $container = $this->getMockBuilder(Container::class)->getMock();
  179. $container->expects($this->once())
  180. ->method('has')
  181. ->with('app.my_controller')
  182. ->willReturn(true)
  183. ;
  184. $container->expects($this->once())
  185. ->method('get')
  186. ->with('app.my_controller')
  187. ->willReturn(new ImpossibleConstructController('toto', 'controller'))
  188. ;
  189. $resolver = $this->createControllerResolver(null, $container);
  190. $request = Request::create('/');
  191. $request->attributes->set('_controller', 'app.my_controller');
  192. $resolver->getController($request);
  193. }
  194. /**
  195. * @dataProvider getUndefinedControllers
  196. */
  197. public function testGetControllerOnNonUndefinedFunction($controller, $exceptionName = null, $exceptionMessage = null)
  198. {
  199. // All this logic needs to be duplicated, since calling parent::testGetControllerOnNonUndefinedFunction will override the expected excetion and not use the regex
  200. $resolver = $this->createControllerResolver();
  201. if (method_exists($this, 'expectException')) {
  202. $this->expectException($exceptionName);
  203. $this->expectExceptionMessageRegExp($exceptionMessage);
  204. } else {
  205. $this->setExpectedExceptionRegExp($exceptionName, $exceptionMessage);
  206. }
  207. $request = Request::create('/');
  208. $request->attributes->set('_controller', $controller);
  209. $resolver->getController($request);
  210. }
  211. public function getUndefinedControllers()
  212. {
  213. return [
  214. ['foo', \LogicException::class, '/Controller not found: service "foo" does not exist\./'],
  215. ['oof::bar', \InvalidArgumentException::class, '/Class "oof" does not exist\./'],
  216. ['stdClass', \LogicException::class, '/Controller not found: service "stdClass" does not exist\./'],
  217. [
  218. 'Symfony\Component\HttpKernel\Tests\Controller\ControllerResolverTest::bar',
  219. \InvalidArgumentException::class,
  220. '/.?[cC]ontroller(.*?) for URI "\/" is not callable\.( Expected method(.*) Available methods)?/',
  221. ],
  222. ];
  223. }
  224. protected function createControllerResolver(LoggerInterface $logger = null, ContainerInterface $container = null)
  225. {
  226. if (!$container) {
  227. $container = $this->createMockContainer();
  228. }
  229. return new ContainerControllerResolver($container, $logger);
  230. }
  231. protected function createMockContainer()
  232. {
  233. return $this->getMockBuilder(ContainerInterface::class)->getMock();
  234. }
  235. }
  236. class InvokableController
  237. {
  238. public function __construct($bar) // mandatory argument to prevent automatic instantiation
  239. {
  240. }
  241. public function __invoke()
  242. {
  243. }
  244. }
  245. abstract class NonInstantiableController
  246. {
  247. public static function action()
  248. {
  249. }
  250. }
  251. class ImpossibleConstructController
  252. {
  253. public function __construct($toto, $controller)
  254. {
  255. }
  256. public function action()
  257. {
  258. }
  259. }